-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix crash when selectin the bank account picker placeholder item #42404
Merged
chiragsalian
merged 1 commit into
Expensify:main
from
bernhardoj:fix/41069-update-react-native-picker
May 24, 2024
Merged
Fix crash when selectin the bank account picker placeholder item #42404
chiragsalian
merged 1 commit into
Expensify:main
from
bernhardoj:fix/41069-update-react-native-picker
May 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I got maximum attempt when testing on mWeb chrome, so can't record it yet. Screen.Recording.2024-05-21.at.11.16.06.mov |
Reviewer Checklist
Screenshots/VideosAndroid: Native01_Android_Native.mp4Android: mWeb Chrome02_Android_Chrome.mp4iOS: Native03_iOS_Native.mp4iOS: mWeb Safari04_iOS_Safari.mp4MacOS: Chrome / Safari05_MacOS_Chrome.mp4MacOS: Desktop06_MacOS_Desktop.mp4 |
Ollyws
approved these changes
May 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
amyevans
approved these changes
May 22, 2024
69 tasks
🚀 Deployed to staging by https://github.com/chiragsalian in version: 1.4.76-0 🚀
|
6 tasks
🚀 Deployed to production by https://github.com/Beamanator in version: 1.4.76-7 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
A bug in the react native picker crashes the app when we select an item with an empty value. It's fixed in picker 2.7.6, so this PR updates it.
Fixed Issues
$ #41069
PROPOSAL: #41069 (comment)
Tests
Same as QA Steps
Offline tests
Same as QA Steps
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Screen.Recording.2024-05-21.at.11.12.11.mov
Android: mWeb Chrome
iOS: Native
Screen.Recording.2024-05-21.at.11.07.51.mov
iOS: mWeb Safari
Screen.Recording.2024-05-21.at.11.09.06.mov
MacOS: Chrome / Safari
Screen.Recording.2024-05-21.at.11.07.03.mov
MacOS: Desktop
Screen.Recording.2024-05-21.at.11.11.33.mov